Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flick Electric Pricing #135154

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

ZephireNZ
Copy link
Contributor

@ZephireNZ ZephireNZ commented Jan 9, 2025

Proposed change

Bumps PyFlick to fix issues fetching pricing data.

Additionally fixes rendering of entity state and attributes - the downstream API changed to $/kWh so this converts it back to c/kWh for consistency.

ZephireNZ/PyFlick@v1.1.2...v1.1.3

Confirmed working with test account:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@ZephireNZ ZephireNZ changed the title Fix Flick Electric Pricing API Fix Flick Electric Pricing Jan 9, 2025
@ZephireNZ ZephireNZ marked this pull request as ready for review January 9, 2025 06:21
@ZephireNZ
Copy link
Contributor Author

@joostlek Second bugfix PR 🙈 And this time it has been properly vetted and working end to end (albeit with their UAT environment)

Hopefully I haven't missed the deadline for 2025.1.2!

@joostlek joostlek added this to the 2025.1.2 milestone Jan 9, 2025
@home-assistant home-assistant bot marked this pull request as draft January 9, 2025 06:49
@home-assistant
Copy link

home-assistant bot commented Jan 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ZephireNZ ZephireNZ marked this pull request as ready for review January 9, 2025 06:57
@home-assistant home-assistant bot requested a review from joostlek January 9, 2025 06:57
@joostlek joostlek merged commit 2f89267 into home-assistant:dev Jan 9, 2025
65 checks passed
bramkragten pushed a commit that referenced this pull request Jan 9, 2025
@bramkragten bramkragten mentioned this pull request Jan 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flick Electric fails to load data
3 participants