-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flick Electric Pricing #135154
Merged
joostlek
merged 3 commits into
home-assistant:dev
from
ZephireNZ:bugfix/flick-pricing-api
Jan 9, 2025
Merged
Fix Flick Electric Pricing #135154
joostlek
merged 3 commits into
home-assistant:dev
from
ZephireNZ:bugfix/flick-pricing-api
Jan 9, 2025
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
dependency
integration: flick_electric
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Jan 9, 2025
@joostlek Second bugfix PR 🙈 And this time it has been properly vetted and working end to end (albeit with their UAT environment) Hopefully I haven't missed the deadline for 2025.1.2! |
ZephireNZ
commented
Jan 9, 2025
joostlek
requested changes
Jan 9, 2025
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
reviewed
Jan 9, 2025
joostlek
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
dependency
integration: flick_electric
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Bumps PyFlick to fix issues fetching pricing data.
Additionally fixes rendering of entity state and attributes - the downstream API changed to $/kWh so this converts it back to c/kWh for consistency.
ZephireNZ/PyFlick@v1.1.2...v1.1.3
Confirmed working with test account:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)Tests have been added to verify that the new code works.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: