Replace climate fan speed 'silent' with a button #135075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
8 tasks
joostlek
requested changes
Jan 9, 2025
| """Representation of a Palazzetti Silent button.""" | ||
|
|
||
| _attr_translation_key = "silent" | ||
| _attr_icon = "mdi:volume-mute" |
| await setup_integration(hass, mock_config_entry) | ||
|
|
||
| mock_palazzetti_client.set_fan_silent.side_effect = CommunicationError() | ||
| with pytest.raises(HomeAssistantError): |
There was a problem hiding this comment.
Suggested change
| with pytest.raises(HomeAssistantError): | |
| with pytest.raises(HomeAssistantError, match=".."): |
Let's also assert the raised error message
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
approved these changes
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Upon talking with users and studying the existing API, we found that 'silent' is not an actual fan speed for the stove. The models that have a 'silent' mode are setting the main + secondary fans speed to 0 and combustion power to 3. Silent is more a shortcut than a state.
This PR creates a button to trigger the silent mode, removes the fan_mode 'silent', and fixes a bug where it was not possible to change the fan_mode to '0'.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Palazzetti integration: Add fan speed 0 and silent mode home-assistant.io#36826
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: