Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors in automation (instead of raise unexpected error) in Overkiz #135026

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Catch errors in automation (instead of raise unexpected error) in Overkiz #135026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/overkiz/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from urllib.parse import urlparse

from pyoverkiz.enums import OverkizCommand, Protocol
from pyoverkiz.exceptions import OverkizException
from pyoverkiz.exceptions import BaseOverkizException
from pyoverkiz.models import Command, Device, StateDefinition
from pyoverkiz.types import StateType as OverkizStateType

Expand Down Expand Up @@ -105,7 +105,7 @@
"Home Assistant",
)
# Catch Overkiz exceptions to support `continue_on_error` functionality
except OverkizException as exception:
except BaseOverkizException as exception:

Check warning on line 108 in homeassistant/components/overkiz/executor.py

View check run for this annotation

Codecov / codecov/patch

homeassistant/components/overkiz/executor.py#L108 

Added line #L108 was not covered by tests
raise HomeAssistantError(exception) from exception

# ExecutionRegisteredEvent doesn't contain the device_url, thus we need to register it here
Expand Down