-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix playing TTS and local media source over DLNA #134903
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
2797f8a
to
185ccd5
Compare
578394c
to
1007088
Compare
1007088
to
59ff434
Compare
Just to confirm that this also fixes streaming video to my Samsung TV. |
Proposed change
If I try TTS or playing a local media audio file on a DLNA compatible speaker, it doesn't work and shows an error in the log:
Right before the
Resource not found
error above, the HA logs show that there's a HEAD request coming in from the speaker and that fails with an HTTP 500 error. I also saw somewhere someone hinting that DLNA renderers might send a HEAD request before sending the GET one.This PR adds support for
HEAD
requests for local_source media and TTS (also allowing signed requests forHEAD
), which fixes this problem and likely related issues mentioned below.Type of change
Additional information
There are several reports around the net about this or related DLNA problems, dating back to 2022:
Most replies to such issues end up pointing to configuring
media_dirs
(Setting up local media sources, Media Source), but nothing works, leading to complains about unclear documentation: home-assistant/home-assistant.io#28940.Also, the documentation says there might be hiccups with Samsung devices, but that might be exactly because of the missing support for HEAD requests:
However, I haven't tried streaming videos yet. I'll check it later and submit a separate PR if necessary, and it seems to also be an issue like #67618.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: