-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bleak-esphome to 2.0.0 #134580
Bump bleak-esphome to 2.0.0 #134580
Conversation
There is a fix to move the caching to be per ESP device since different ESP chips/major versions can generate different services for the same device. Previously we had a global cache that was shared between all ESPHome Bluetooth proxies which could result in writing to the wrong handle if all the ESPs were not the same changelog: Bluetooth-Devices/bleak-esphome@v1.1.0...v2.0.0
Hey there @OttoWinter, @jesserockz, @kbx81, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks |
Proposed change
There is a fix to move the caching to be per ESP device since different ESP chips/major versions can generate different services for the same device. Previously we had a global cache that was shared between all ESPHome Bluetooth proxies which could result in writing to the wrong handle if all the ESPs were not the same
changelog: Bluetooth-Devices/bleak-esphome@v1.1.0...v2.0.0
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: