-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add radioactivity concentration units #134376
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jcgillespie
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This PR is changing our entity model. Before we can review this PR there needs to be approval in a discussion in our architecture repository. https://github.com/home-assistant/architecture/discussions https://developers.home-assistant.io/docs/core/entity#changing-the-entity-model |
@joostlek My apologies. I didn't realize there was a different workflow for this kind of change. This is my first PR. A quick search shows at least three related discussions. I'll weigh in there.
I also have branches ready for some of the integrations that could consume these changes. |
a3bccc4
to
46097b4
Compare
Please ensure that:
|
The thing is, we should not be opening Pull Requests for things that are still awaiting architectural approval. This PR is not actionable right now. ../Frenck |
Understood. I didn’t realize it would require an architectural decision when I made the PR. I can either make the updates @epenet requested in anticipation of a decision, or I can close/abandon this PR. Which direction is more appropriate? The discussion is primarily in #886, it there is also some in 732 and 999. |
Proposed change
Adds radioactivity concentration units of measure to support radon sensors and conversion between Metric and USCS measures. These are changes to core that will enable feature requests like this and this
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: