Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radioactivity concentration units #134376

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jcgillespie
Copy link

@jcgillespie jcgillespie commented Jan 1, 2025

Proposed change

Adds radioactivity concentration units of measure to support radon sensors and conversion between Metric and USCS measures. These are changes to core that will enable feature requests like this and this

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: Documentation PR

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jcgillespie jcgillespie requested a review from a team as a code owner January 1, 2025 00:56
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcgillespie

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Jan 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 1, 2025 00:56
@home-assistant
Copy link

home-assistant bot commented Jan 1, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

joostlek commented Jan 1, 2025

This PR is changing our entity model. Before we can review this PR there needs to be approval in a discussion in our architecture repository.

https://github.com/home-assistant/architecture/discussions

https://developers.home-assistant.io/docs/core/entity#changing-the-entity-model

@jcgillespie
Copy link
Author

@joostlek My apologies. I didn't realize there was a different workflow for this kind of change. This is my first PR.

A quick search shows at least three related discussions. I'll weigh in there.

I also have branches ready for some of the integrations that could consume these changes.

@MartinHjelmare MartinHjelmare marked this pull request as draft January 1, 2025 07:16
@jcgillespie
Copy link
Author

jcgillespie commented Jan 1, 2025

@epenet Thanks for catching. I didn't realize the generic sensor integration had device types documented. Documentation PR is here

@epenet
Copy link
Contributor

epenet commented Jan 2, 2025

Please ensure that:

  • number device classes are aligned with sensor device classes
  • RADIOACTIVITY_CONCENTRATION is added below REACTIVE_POWER (alphabetical order)
  • main documentation is also adjusted for number integration
  • and that a separate PR is created on the developper documentation repository

@frenck
Copy link
Member

frenck commented Jan 2, 2025

The thing is, we should not be opening Pull Requests for things that are still awaiting architectural approval. This PR is not actionable right now.

../Frenck

@jcgillespie
Copy link
Author

Understood. I didn’t realize it would require an architectural decision when I made the PR. I can either make the updates @epenet requested in anticipation of a decision, or I can close/abandon this PR. Which direction is more appropriate?

The discussion is primarily in #886, it there is also some in 732 and 999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants