Skip to content

Conversation

simon-bonnedahl
Copy link

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @simon-bonnedahl

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution. You will however need to move your library code. Also, you'll need to add at least 100% test coverage for the config flow and also fulfill all "bronze" criteria in the quality scale.

Comment on lines +48 to +81
class LKWebServerAPI:
"""An API client for the LK Systems webserver."""

def __init__(self, email, password) -> None:
"""Initialize the API client."""
self.base_url = "https://my.lk.nu"
self.email = email
self.password = password
self.session = None

async def login(self):
"""Log in to the LK Systems API and initialize the session."""
if self.session is None:
self.session = aiohttp.ClientSession()

login_url = f"{self.base_url}/login"
payload = {"email": self.email, "password": self.password}
async with self.session.post(login_url, data=payload) as response:
response.raise_for_status()
result = await response.json()
if result.get("error") == "1":
_LOGGER.error("Login failed: %s", result.get("msg", "Unknown error"))
raise InvalidAuth(result.get("msg", "Access denied."))

async def get_main_data(self):
"""Fetch the main data from the LK Systems webserver."""
url = f"{self.base_url}/main.json"
if self.session is None:
return {}
async with self.session.get(url) as response:
response.raise_for_status()
return await response.json()

async def set_room_temperature(self, zone_id, temperature) -> dict:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library code (this) needs to be place in a public git repository, together with an OSI approved license, needs to be pushed to PyPi through CICD and installed from there in HA

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see. Too much work for me. Hopefully someone can follow this up.

@home-assistant home-assistant bot marked this pull request as draft December 29, 2024 14:41
@MartinHjelmare MartinHjelmare changed the title Added LK Systems floor heating integration Add LK Systems floor heating integration Feb 23, 2025
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Apr 24, 2025
@github-actions github-actions bot closed this May 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants