Use x,y in roborock action call #134133
Use x,y in roborock action call #134133
Conversation
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: roborock
small-pr
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| "description": "" | ||
| }, | ||
| "y_coord": { | ||
| "y": { | ||
| "name": "Y-coordinate", | ||
| "description": "" |
There was a problem hiding this comment.
Why do we have an empty description? I think it would be valuable to have something here that tells you what this value is
There was a problem hiding this comment.
If you have a suggestion... but I did not see it, hence leaving it empty to avoid unnecessary translations.
There was a problem hiding this comment.
Maybe it would be nice to explain what way it is, as in, higher X -> more to the front, higher Y -> go to the right? Or is that an incorrect assumption
There was a problem hiding this comment.
It's all coordinates with the base station as reference... Maybe we should set something there.
There was a problem hiding this comment.
"The x coordinate as seen from the base station of the vaccum"
I think something like this would also explain the user why it wouldn't work anymore if you moved the base station
There was a problem hiding this comment.
Has been updated so let me see what you think 👍
Proposed change
Rename parameters for
set_vacuum_goto_positionaction call inroborock(for consistency).the call has not been released, so not breaking.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: