Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nord Pool empty response #134033

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Fix Nord Pool empty response #134033

merged 3 commits into from
Dec 28, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Dec 26, 2024

Proposed change

Fixes Nord Pool empty responses for future dates.
https://github.com/gjohansson-ST/pynordpool/releases/tag/v0.2.4
gjohansson-ST/pynordpool@v0.2.3...v0.2.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@gjohansson-ST gjohansson-ST marked this pull request as ready for review December 26, 2024 16:10
Copy link
Contributor

@austinmroczek austinmroczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could add a test for the new exception handling you added.

homeassistant/components/nordpool/sensor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@austinmroczek austinmroczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a diff? (The release also doesn't have one)

@home-assistant home-assistant bot marked this pull request as draft December 27, 2024 16:59
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@gjohansson-ST gjohansson-ST marked this pull request as ready for review December 27, 2024 17:14
@zweckj zweckj merged commit 645f2e4 into dev Dec 28, 2024
65 checks passed
@zweckj zweckj deleted the gj-20241226-01 branch December 28, 2024 20:38
sstallion pushed a commit to sstallion/homeassistant-core that referenced this pull request Dec 29, 2024
* Fix Nord Pool empty response

* Mods

* reset validate prices
balloob pushed a commit that referenced this pull request Dec 29, 2024
* Fix Nord Pool empty response

* Mods

* reset validate prices
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nord pool empty response | cannot initialize integration
4 participants