-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Nord Pool empty response #134033
Fix Nord Pool empty response #134033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if you could add a test for the new exception handling you added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a diff? (The release also doesn't have one)
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
* Fix Nord Pool empty response * Mods * reset validate prices
* Fix Nord Pool empty response * Mods * reset validate prices
Proposed change
Fixes Nord Pool empty responses for future dates.
https://github.com/gjohansson-ST/pynordpool/releases/tag/v0.2.4
gjohansson-ST/pynordpool@v0.2.3...v0.2.4
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: