Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suez_water: clear quality scale #134027

Merged

Conversation

jb101010-2
Copy link
Contributor

@jb101010-2 jb101010-2 commented Dec 26, 2024

Revert invalid done rules and mark inapplicable ones as exempted.

Proposed change

Clean up quality_scale of suez water integration, some rules where misunderstood due to a lack of knowledge in HA internals.
A bit clearer now on what's left to do - lots of doc 😄.

Fortunately this did not provoke a rollback on scale level.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration (suez_water) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of suez_water can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign suez_water Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jb101010-2 jb101010-2 marked this pull request as draft December 26, 2024 09:50
@jb101010-2 jb101010-2 marked this pull request as ready for review December 26, 2024 09:56
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 27, 2024 16:51
@jb101010-2 jb101010-2 force-pushed the feat_suez-quality-scale-clean-up branch from c9c53ac to c0fa8d9 Compare December 28, 2024 08:16
@jb101010-2
Copy link
Contributor Author

all done, more or less 😄

@jb101010-2 jb101010-2 marked this pull request as ready for review December 28, 2024 08:36
@home-assistant home-assistant bot requested a review from zweckj December 28, 2024 08:36
@jb101010-2 jb101010-2 force-pushed the feat_suez-quality-scale-clean-up branch from 426f4db to ff4ef12 Compare December 28, 2024 08:43
@home-assistant home-assistant bot marked this pull request as draft December 28, 2024 10:11
@jb101010-2 jb101010-2 force-pushed the feat_suez-quality-scale-clean-up branch from 720216e to 2c901e2 Compare December 28, 2024 17:42
@jb101010-2 jb101010-2 marked this pull request as ready for review December 28, 2024 17:42
@home-assistant home-assistant bot requested a review from zweckj December 28, 2024 17:42
@zweckj zweckj merged commit 72a9624 into home-assistant:dev Dec 28, 2024
34 checks passed
@jb101010-2 jb101010-2 deleted the feat_suez-quality-scale-clean-up branch December 28, 2024 20:00
sstallion pushed a commit to sstallion/homeassistant-core that referenced this pull request Dec 29, 2024
* Suez_water: clear quality scale

Revert invalid done rules and mark inapplicable ones as exempted.

* Mark entity disabled as todo

* Mark devices as todo

* missing push

* Update homeassistant/components/suez_water/quality_scale.yaml

Co-authored-by: Josef Zweck <josef@zweck.dev>

* Update quality_scale.yaml

* Update quality_scale.yaml again

---------

Co-authored-by: Josef Zweck <josef@zweck.dev>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants