-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suez_water: clear quality scale #134027
Merged
zweckj
merged 7 commits into
home-assistant:dev
from
jb101010-2:feat_suez-quality-scale-clean-up
Dec 28, 2024
Merged
Suez_water: clear quality scale #134027
zweckj
merged 7 commits into
home-assistant:dev
from
jb101010-2:feat_suez-quality-scale-clean-up
Dec 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
integration: suez_water
small-pr
PRs with less than 30 lines.
quality-scale
labels
Dec 26, 2024
Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
zweckj
requested changes
Dec 27, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jb101010-2
force-pushed
the
feat_suez-quality-scale-clean-up
branch
from
December 28, 2024 08:16
c9c53ac
to
c0fa8d9
Compare
all done, more or less 😄 |
jb101010-2
force-pushed
the
feat_suez-quality-scale-clean-up
branch
from
December 28, 2024 08:43
426f4db
to
ff4ef12
Compare
zweckj
requested changes
Dec 28, 2024
Revert invalid done rules and mark inapplicable ones as exempted.
Co-authored-by: Josef Zweck <josef@zweck.dev>
jb101010-2
force-pushed
the
feat_suez-quality-scale-clean-up
branch
from
December 28, 2024 17:42
720216e
to
2c901e2
Compare
zweckj
approved these changes
Dec 28, 2024
sstallion
pushed a commit
to sstallion/homeassistant-core
that referenced
this pull request
Dec 29, 2024
* Suez_water: clear quality scale Revert invalid done rules and mark inapplicable ones as exempted. * Mark entity disabled as todo * Mark devices as todo * missing push * Update homeassistant/components/suez_water/quality_scale.yaml Co-authored-by: Josef Zweck <josef@zweck.dev> * Update quality_scale.yaml * Update quality_scale.yaml again --------- Co-authored-by: Josef Zweck <josef@zweck.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
code-quality
integration: suez_water
Quality Scale: bronze
quality-scale
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert invalid done rules and mark inapplicable ones as exempted.
Proposed change
Clean up quality_scale of suez water integration, some rules where misunderstood due to a lack of knowledge in HA internals.
A bit clearer now on what's left to do - lots of doc 😄.
Fortunately this did not provoke a rollback on scale level.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: