-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suez_water: use meter id as unique_id #133959
Suez_water: use meter id as unique_id #133959
Conversation
Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
a8802d8
to
82dd90c
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
82dd90c
to
035e014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few remaining things
f7060d1
to
2001134
Compare
all done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jb101010-2 👍
Proposed change
Change unique_id for suez_water use meter id instead of username which can be changed.
This change is made in prevision of reauth flow which will allow the user to change it's username.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: