Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suez_water: use meter id as unique_id #133959

Merged
merged 5 commits into from
Dec 28, 2024

Conversation

jb101010-2
Copy link
Contributor

Proposed change

Change unique_id for suez_water use meter id instead of username which can be changed.
This change is made in prevision of reauth flow which will allow the user to change it's username.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration (suez_water) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of suez_water can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign suez_water Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jb101010-2 jb101010-2 marked this pull request as ready for review December 24, 2024 13:49
@jb101010-2 jb101010-2 force-pushed the feat_suez-meter-unique branch from a8802d8 to 82dd90c Compare December 26, 2024 07:28
homeassistant/components/suez_water/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/suez_water/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/suez_water/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/suez_water/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/suez_water/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/suez_water/config_flow.py Outdated Show resolved Hide resolved
tests/components/suez_water/conftest.py Outdated Show resolved Hide resolved
tests/components/suez_water/conftest.py Outdated Show resolved Hide resolved
tests/components/suez_water/test_init.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 26, 2024 23:34
@jb101010-2 jb101010-2 force-pushed the feat_suez-meter-unique branch from 82dd90c to 035e014 Compare December 27, 2024 09:47
@jb101010-2 jb101010-2 marked this pull request as ready for review December 27, 2024 09:54
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few remaining things

homeassistant/components/suez_water/__init__.py Outdated Show resolved Hide resolved
tests/components/suez_water/test_init.py Outdated Show resolved Hide resolved
tests/components/suez_water/test_init.py Outdated Show resolved Hide resolved
tests/components/suez_water/test_init.py Outdated Show resolved Hide resolved
tests/components/suez_water/test_init.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 27, 2024 20:56
@jb101010-2 jb101010-2 force-pushed the feat_suez-meter-unique branch from f7060d1 to 2001134 Compare December 28, 2024 08:10
@jb101010-2
Copy link
Contributor Author

all done

@jb101010-2 jb101010-2 marked this pull request as ready for review December 28, 2024 08:10
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jb101010-2 👍

@gjohansson-ST gjohansson-ST merged commit e58bd62 into home-assistant:dev Dec 28, 2024
34 checks passed
@jb101010-2 jb101010-2 deleted the feat_suez-meter-unique branch December 28, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants