Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality_scale.yaml for KNX #133937

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Add quality_scale.yaml for KNX #133937

merged 2 commits into from
Dec 28, 2024

Conversation

farmio
Copy link
Contributor

@farmio farmio commented Dec 24, 2024

Bronze

Silver

  • config-entry-unloading - Support config entry unloading
    async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
  • log-when-unavailable - If internet/device/service is unavailable, log once when unavailable and once when back connected
  • entity-unavailable - Mark entity unavailable if appropriate
    def available(self) -> bool:
    """Return True if entity is available."""
    return self._knx_module.connected
  • action-exceptions - Service actions raise exceptions when encountering failures
  • reauthentication-flow - Reauthentication flow
  • parallel-updates - Set Parallel updates
  • test-coverage - Above 95% test coverage for all integration modules
  • integration-owner - Has an integration owner
    https://github.com/home-assistant/core/blob/dev/homeassistant/components/knx/manifest.json
  • docs-installation-parameters - The documentation describes all integration installation parameters
  • docs-configuration-parameters - The documentation describes all integration configuration options

Gold

  • entity-translations - Entities have translated names
  • entity-device-class - Entities use device classes where possible
  • devices - The integration creates devices
  • entity-category - Entities are assigned an appropriate EntityCategory
  • entity-disabled-by-default - Integration disables less popular (or noisy) entities
  • discovery - Can be discovered
  • stale-devices - Clean up stale devices
  • diagnostics - Implements diagnostics
    https://github.com/home-assistant/core/blob/dev/homeassistant/components/knx/diagnostics.py
  • exception-translations - Exception messages are translatable
  • icon-translations - Icon translations
  • reconfiguration-flow - Integrations should have a reconfigure flow
  • dynamic-devices - Devices added after integration setup
  • discovery-update-info - Integration uses discovery info to update network information
  • repair-issues - Repair issues and repair flows are used when user intervention is needed
  • docs-use-cases - The documentation describes use cases to illustrate how this integration can be used
  • docs-supported-devices - The documentation describes known supported / unsupported devices
  • docs-supported-functions - The documentation describes the supported functionality, including entities, and platforms
  • docs-data-update - The documentation describes how data is updated
  • docs-known-limitations - The documentation describes known limitations of the integration (not to be confused with bugs)
  • docs-troubleshooting - The documentation provides troubleshooting information
  • docs-examples - The documentation provides automation examples the user can use.

Platinum

  • async-dependency - Dependency is async
  • inject-websession - The integration dependency supports passing in a websession
  • strict-typing - Strict typing

@home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing (all seems related to missing translations)

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 27, 2024 20:43
@farmio
Copy link
Contributor Author

farmio commented Dec 27, 2024

Should be fixed by #134078

@farmio farmio marked this pull request as ready for review December 27, 2024 20:53
@gjohansson-ST gjohansson-ST merged commit 6dbcd13 into dev Dec 28, 2024
34 checks passed
@gjohansson-ST gjohansson-ST deleted the knx-iqs branch December 28, 2024 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants