Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure integration platform loader does not try to load same named platforms #133911

Closed
wants to merge 1 commit into from
Closed

Ensure integration platform loader does not try to load same named platforms #133911

wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 23, 2024 •
edited
Loading

Proposed change

The integration platform loader would try to load backup.backup as an integration platform and delay startup because it had to get in line to use the import executor. We should never have an integration platform for the same named integration being loaded.

It turns out this was intended

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco
Ensure integration platform loader does not try to load itself
04a7567 
The integration platform would try to load backup.backup as an
integration platform. We should never have an integration
platform for the integration being loaded.
@bdraco bdraco added this to the 2025.1.0 milestone Dec 23, 2024
@bdraco bdraco changed the title Ensure integration platform loader does not try to load itself Ensure integration platform loader does not try to load same named platforms Dec 23, 2024
@bdraco bdraco marked this pull request as ready for review December 23, 2024 19:08
@bdraco bdraco requested a review from a team as a code owner December 23, 2024 19:08
@bdraco bdraco marked this pull request as draft December 23, 2024 19:35
@bdraco bdraco closed this Dec 23, 2024
@bdraco
Copy link
Member Author

bdraco commented Dec 23, 2024

Looks like the intent was to have backup.backup be an integration platform.

Need to change the approach to pre-load instead

@bdraco bdraco removed this from the 2025.1.0 milestone Dec 23, 2024
@bdraco
Copy link
Member Author

bdraco commented Dec 23, 2024

adjusted #133907 instead

@bdraco bdraco deleted the integration_platforms_no_load_self branch December 23, 2024 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix cla-signed core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco