-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword invoke_pin action to avoid misunderstanding with "PIN" #133665
Conversation
The previous mismatch between "PIN" and "pin" in the invoke_pin caused wrong translations as "PIN" was interpreted as the abbreviation for "Personal Identification Number". This commit fixes this by explaining "pin" as related to "pinning" content on the device. In addition the very "invoke" is replaced by "play" which every user and translator will understand immediately. Along with those changes this commit reverts my previous change to "PIN" in all strings that made things worse.
Hey there @bazwilliams, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the other pins? Can those stay caps?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@zweckj As suggested by @bazwilliams I changed all occurences of "PIN" to "pin" so it no longer looks like the abbreviation. There are six Pins on the device and Linn's docs also use both spellings. Here a mockup of all the changes in the UI: |
That one I'm happy with, the others could still be improved imo -> check suggestions |
@zweckj Everything contained in the strings.json is visible in my mockup above. So if the mockup is OK with you and @bazwilliams there is nothing left to change? |
Proposed change
The previous mismatch between "PIN" and "pin" in the invoke_pin action caused wrong translations as "PIN" was interpreted as the abbreviation for "Personal Identification Number".
This commit fixes this by explaining "pin" as related to "pinning" content on the device.
In addition the very technical term "invoke" is replaced by "play" which every user and translator will understand immediately.
Along with those changes this PR reverts my previous PR to use "PIN" in all strings that made things worse.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: