Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear shopping list button for Cookidoo #133583

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Dec 19, 2024

Proposed change

Add a reset button to clear both lists shopping list and additional purchases together. This mirrors the functionality available in the App.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj zweckj marked this pull request as draft December 19, 2024 19:50
@miaucl miaucl marked this pull request as ready for review December 19, 2024 20:36
@zweckj zweckj marked this pull request as draft December 20, 2024 07:27
@miaucl miaucl marked this pull request as ready for review December 24, 2024 15:46
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects actions-exceptions on the quality scale. Either set it back to todo or handle (and translate the exception)

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 24, 2024 18:28
@miaucl miaucl marked this pull request as ready for review December 25, 2024 13:38
@home-assistant home-assistant bot requested a review from zweckj December 25, 2024 13:38
@zweckj zweckj merged commit 60774c6 into home-assistant:dev Dec 25, 2024
34 checks passed
@miaucl miaucl deleted the cookidoo_clear_button branch December 25, 2024 14:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants