Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fjäråskupan to 2.3.2 #133499

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Dec 18, 2024

Proposed change

Upgrade fjäråskupan to 2.3.2

Fixes issues with light not able to turn of from home assistant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@elupus
Copy link
Contributor Author

elupus commented Dec 18, 2024

Let's leave this for beta cycle, will ask people in the issue list to test the beta release when it's out. I've not been able to reproduce the issue they have, so its somewhat a shot in the dark.

@joostlek joostlek added this to the 2024.12.5 milestone Dec 18, 2024
@joostlek joostlek removed this from the 2024.12.5 milestone Dec 18, 2024
@joostlek
Copy link
Member

You can have them install this PR as custom component and test that way maybe?

@joostlek
Copy link
Member

cd /config
curl -o- -L https://gist.githubusercontent.com/bdraco/43f8043cb04b9838383fd71353e99b18/raw/core_integration_pr | bash /dev/stdin -d fjaraskupan -p 133499

@elupus
Copy link
Contributor Author

elupus commented Dec 18, 2024

I've asked them to test during beta. No real rush unless they feel the pressure :).

@elupus elupus merged commit a6089b4 into home-assistant:dev Dec 18, 2024
61 checks passed
@elupus elupus deleted the fjaraskupan/2.3.2 branch December 18, 2024 17:03
@elupus elupus added this to the 2024.12.5 milestone Dec 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light turn off command immediately toggles to on automatically
3 participants