Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suez_water: fix yesterday sensor extra_state invalid typing #133425

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

jb101010-2
Copy link
Contributor

@jb101010-2 jb101010-2 commented Dec 17, 2024

Proposed change

Extra states attributes of yestderday sensor where stored as a date because of a not respected type.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #133416 - issue seems to exists but github does not display it 😅
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration (suez_water) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of suez_water can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign suez_water Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jb101010-2 jb101010-2 marked this pull request as ready for review December 17, 2024 12:58
@epenet epenet changed the title Suez_water: fix yestderday sensor extra_state invalid typing Suez_water: fix yesterday sensor extra_state invalid typing Dec 17, 2024
@jb101010-2 jb101010-2 force-pushed the fix_suez-extra-types branch 4 times, most recently from 335cf43 to 30883ee Compare December 21, 2024 20:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jb101010-2 👍

../Frenck

@frenck frenck merged commit a3657a0 into home-assistant:dev Dec 22, 2024
34 checks passed
@jb101010-2 jb101010-2 deleted the fix_suez-extra-types branch December 23, 2024 07:21
@jb101010-2
Copy link
Contributor Author

Just a quick question. I never was able to see the issue (404 every time), I know it existed because the author gave me the number and because github displayed its status.
Is there a reason for that?

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants