Add tests for Habitica integration #131780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: habitica
small-pr
73 tasks
jsuar
approved these changes
Dec 9, 2024
19 tasks
tr4nt0r
force-pushed
the
habitica_tests
branch
from
b96c0a7 to
855f47c
Compare
zweckj
approved these changes
Dec 17, 2024
| f"{DEFAULT_URL}/api/v3/user", | ||
| json=load_json_object_fixture("wizard_fixture.json", DOMAIN), | ||
| ) | ||
| aioclient_mock.get( |
There was a problem hiding this comment.
in general, I don't like direct aioclient mocks in HA. Instead I'd recommend mocking the library's client. Since the other tests are already using this pattern, I'll allow it. Maybe you think about changing this from the entire tests in the future.
There was a problem hiding this comment.
i know i know, but that is not possible here. There's a PR that introduces a new library and all tests have been rewritten accordingly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds an additional test case to the fixtures and a test for unloading and loading of buttons when user changes class
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: