Skip to content

Conversation

klaasnicolaas
Copy link
Member

@klaasnicolaas klaasnicolaas commented Nov 26, 2024

Proposed change

This PR will add the Powerfox integration to get (currently only) your power and water meter data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck
Copy link
Member

frenck commented Nov 26, 2024

Marked draft, as there are CI errors.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 27, 2024 15:51
@abmantis
Copy link
Member

abmantis commented Dec 3, 2024

LGTM. Should this be moved out of draft?

@klaasnicolaas klaasnicolaas marked this pull request as ready for review December 3, 2024 10:31
@home-assistant home-assistant bot requested a review from abmantis December 3, 2024 10:31
@home-assistant home-assistant bot marked this pull request as draft December 3, 2024 11:27
@joostlek joostlek marked this pull request as ready for review December 3, 2024 23:35
@home-assistant home-assistant bot requested a review from joostlek December 3, 2024 23:35
@joostlek joostlek merged commit abd3466 into home-assistant:dev Dec 3, 2024
61 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants