Add palazzetti status sensor #131348
Merged
Add palazzetti status sensor #131348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
dotvav
force-pushed
the
palazzetti_status_sensor
branch
from
1d9c49c to
031c6e5
Compare
zweckj
reviewed
Nov 25, 2024
| @@ -17,3 +17,53 @@ | |||
| FAN_HIGH: Final = "high" | |||
| FAN_AUTO: Final = "auto" | |||
| FAN_MODES: Final = [FAN_SILENT, "1", "2", "3", "4", "5", FAN_HIGH, FAN_AUTO] | |||
|
|
|||
| STATUSES: Final[dict[str | int | float | None, str]] = { | |||
There was a problem hiding this comment.
Suggested change
| STATUSES: Final[dict[str | int | float | None, str]] = { | |
| STATUS_TO_HA: Final[dict[int, str]] = { |
just preference to understand that this is a label mapping
There was a problem hiding this comment.
Out of curiosity, do you think there is value to making this mapping in the library instead of in the integration?
There was a problem hiding this comment.
personally I'd probably just make it an IntEnum in the libary, so I don't have to think/remember what each of that codes is.
|
Flipping to draft while I figure out why the snapshot test is failing (works on my computer). |
dotvav
force-pushed
the
palazzetti_status_sensor
branch
from
704ad22 to
b00898b
Compare
Translations updated, snapshot updated, all checks now passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add an enum status sensor to the palazzetti integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: