Add quality scale for nest integration #131330
Conversation
|
Update some status that were incorrect and added more detailed comments in the status. |
| The integration does a connection test in the configuration flow, however | ||
| it does not fail if the user has ipv6 misconfigured. |
There was a problem hiding this comment.
how does that work
There are multiple APIs. There is the SDM API, then there is also the pubsub subscriber API. Right now it is only testing the SDM API and the pubsub subscriber is what often fails due to users misconfigurations of ipv6.
There was a problem hiding this comment.
My impression is that this is the first time people notice since google uses ipv6 and not as many other things do. I think it would be nice if this could be detected some other way like Home Assistant noticing its misconfigured and not setting up the user with ipv6, but i'm not an ipv6 expert at all to know what makes sense here.
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
| observed are related to ipv6 misconfigurations and the error messages | ||
| are not self explanatory and can be improved. | ||
| docs-high-level-description: done | ||
| config-flow-test-coverage: done |
There was a problem hiding this comment.
Is it possible for the user to reauth with a different account?
There was a problem hiding this comment.
I believe the original choice to use device access project id was because the nest API does not return any notion of identity. The device access project is currently the unique id and we've asked users to set this up to create their own project id, but theoretically you could share them across accounts.
In years following, the pattern that newer google integrations have followed is to additionally query the user identify API to get the account information. We could follow here also and enforce going forward.
There was a problem hiding this comment.
I added this as a comment for re-authentication item in the silver category (didn't yet grade this yet)
There was a problem hiding this comment.
Would sound nice, also if we can add more tests for that when that happens :)
There was a problem hiding this comment.
Of course -- all changes come with tests :)
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Unmark config flow test coverage as done.
Proposed change
Add quality scale for nest integration and tag currently implemented features of the bronze scale.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: