Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UniFi Protect icr_lux min to 0 allowing "below 1 lux" #131115

Conversation

RaHehl
Copy link
Contributor

@RaHehl RaHehl commented Nov 20, 2024

Breaking change

Proposed change

This is the UI part of Fixing
fixes #122408
fixes #124093
fixes #124717

Requires #131107 to be merged

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@TheJulianJES TheJulianJES mentioned this pull request Nov 20, 2024
19 tasks
@TheJulianJES TheJulianJES changed the title unifiprotect set icr_lux min 0 to allow setting "below 1 lux" Set UniFi Protect icr_lux min to 0 allowing "below 1 lux" Nov 20, 2024
@bdraco bdraco merged commit bab9ef7 into home-assistant:dev Nov 21, 2024
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@RaHehl RaHehl deleted the unifiprotect-fix-icr-custom-value-0-not-selectable branch November 24, 2024 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants