Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Habitica integration to habiticalib #131032

Merged
merged 27 commits into from
Dec 29, 2024

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Nov 20, 2024

Proposed change

Migration of Habitica integration to new library

New library: https://github.com/tr4nt0r/habiticalib/releases/tag/v0.3.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck
Copy link
Member

frenck commented Nov 24, 2024

Not sure on the state of this PR (as it has WIP in the PR title, although not a pattern we commonly use).

I've marked it draft for that reason for now.

@tr4nt0r tr4nt0r changed the title WIP: Migrate Habitica config flow to habiticalib Migrate Habitica config flow to habiticalib Nov 24, 2024
@tr4nt0r tr4nt0r marked this pull request as ready for review November 24, 2024 18:01
@tr4nt0r tr4nt0r changed the title Migrate Habitica config flow to habiticalib Migrate Habitica integration to habiticalib Nov 24, 2024
@tr4nt0r tr4nt0r force-pushed the habiticalib_migration branch 3 times, most recently from 4af3382 to a7ea5c3 Compare November 28, 2024 14:03
@tr4nt0r tr4nt0r mentioned this pull request Nov 28, 2024
73 tasks
homeassistant/components/habitica/button.py Show resolved Hide resolved
homeassistant/components/habitica/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/habitica/services.py Outdated Show resolved Hide resolved
homeassistant/components/habitica/services.py Outdated Show resolved Hide resolved
homeassistant/components/habitica/services.py Show resolved Hide resolved
homeassistant/components/habitica/todo.py Show resolved Hide resolved
homeassistant/components/habitica/util.py Show resolved Hide resolved
homeassistant/components/habitica/util.py Show resolved Hide resolved
tests/components/habitica/test_todo.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 28, 2024 21:16
@tr4nt0r tr4nt0r marked this pull request as ready for review November 29, 2024 00:22
@home-assistant home-assistant bot requested a review from allenporter November 29, 2024 00:22
@tr4nt0r tr4nt0r force-pushed the habiticalib_migration branch from 9479033 to cd37ecb Compare November 29, 2024 11:47
@tr4nt0r tr4nt0r requested a review from allenporter November 29, 2024 11:53
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict, can you take a look?

@tr4nt0r tr4nt0r force-pushed the habiticalib_migration branch from 8dca89d to e231727 Compare December 17, 2024 23:09
tests/components/habitica/test_todo.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 18, 2024 09:38
@tr4nt0r tr4nt0r marked this pull request as ready for review December 18, 2024 22:51
@home-assistant home-assistant bot requested a review from joostlek December 18, 2024 22:51
@tr4nt0r tr4nt0r force-pushed the habiticalib_migration branch from 8a0187e to b872615 Compare December 18, 2024 22:55
@zweckj zweckj merged commit 0db07a0 into home-assistant:dev Dec 29, 2024
65 checks passed
sstallion pushed a commit to sstallion/homeassistant-core that referenced this pull request Dec 29, 2024
* Migrate data to habiticalib

* Add habiticalib to init and coordinator

* Migrate Habitica config flow to habiticalib

* migrate init to habiticalib

* migrate buttons to habiticalib

* migrate switch to habiticalib

* update habiticalib

* cast_skill action

* migrate update_score

* migrate transformation items action

* migrate quest actions

* fix fixture errors

* Migrate coordinator data and content

* bump habiticalib

* Remove habitipy and use wrapper in habiticalub

* changes

* some fixes

* minor refactoring

* class_needed annotation

* Update diagnostics

* do integration setup in coordinator setup

* small changes

* raise HomeAssistantError for TooManyRequestsError

* fix docstring

* update tests

* changes to tests/snapshots

* fix update_todo_item
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants