Include backup agent error in response to WS command backup/info #130884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
approved these changes
Nov 18, 2024
|
|
||
|
|
||
| class BackupAgentUnreachableError(BackupAgentError): | ||
| """Raised when the agent can't reach it's API.""" |
There was a problem hiding this comment.
Suggested change
| """Raised when the agent can't reach it's API.""" | |
| """Raised when the agent can't reach its API.""" |
There was a problem hiding this comment.
Fixed in #130890
| agent_backups = await agent.async_list_backups() | ||
| for agent_backup in agent_backups: | ||
| agent_errors: dict[str, Exception] = {} | ||
| agent_ids = list(self.backup_agents.keys()) |
There was a problem hiding this comment.
Suggested change
| agent_ids = list(self.backup_agents.keys()) | |
| agent_ids = list(self.backup_agents) |
There was a problem hiding this comment.
Fixed in #130890
| async def async_get_backups(self, **kwargs: Any) -> dict[str, _BackupT]: | ||
| async def async_get_backups( | ||
| self, **kwargs: Any | ||
| ) -> tuple[dict[str, Backup], dict[str, Exception]]: |
There was a problem hiding this comment.
I'd return a dataclass instead of a tuple. That's more robust for changes.
There was a problem hiding this comment.
I don't think that's motivated when we only ever call this from the WS API
|
Test failures are unrelated |
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Include backup agent error in response to WS command
backup/infoType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: