-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup config storage #130871
Add backup config storage #130871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict.
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
4f891a5
to
0abb521
Compare
if param_value is not UNDEFINED: | ||
setattr(self.data, param_name, param_value) | ||
|
||
await self.save() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating the config this method should take needed actions based on the new config settings. Eg reschedule the next backup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MartinHjelmare 👍
class BackupConfigData: | ||
"""Represent loaded backup config data.""" | ||
|
||
last_automatic_backup: datetime | None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really config, but we need to store this if we want to give consumers the last automatic backup time, regardless of the metadata of any backup files, and also if we want to be able to guard against too frequent backups eg due to DST time changes.
It'll probably also be needed to seed the backup schedule, although that implementation isn't done yet.
0abb521
to
e8d3fd0
Compare
e8d3fd0
to
2f5075a
Compare
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: