Two bugfix and one minor improvement on the VIAGGIATRENO integration #130377
+27
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sensor can have both a numeric or a text value, so setting its unit measure causes an error. Removing the unit measure property solves the issue
The Trenitalia Viaggatreno API wants today's updated time to give today's train information. Setting this value in the init updates it only during startup, so i moved it into the async req
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
bot
added
bugfix
cla-needed
integration: viaggiatreno
small-pr
edenhaus
requested changes
Nov 12, 2024
| @@ -2,6 +2,8 @@ | |||
| "domain": "viaggiatreno", | |||
| "name": "Trenitalia ViaggiaTreno", | |||
| "codeowners": [], | |||
| "dependencies": ["http"], | |||
There was a problem hiding this comment.
Why did you specify the HTTP integration as a dependency?
There was a problem hiding this comment.
Please make sure CI is passing
I see, I'll have to build up the whole development environment locally :S
Why did you specify the HTTP integration as a dependency?
beacuse I am ignorant ad i saw from http import HTTPStatus at the beginning of the sensor.py file. i tried to do the update manifest task to the best of my knowledge
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
BUGFIX only: #129026 and #130103
Disclaimer
I am the sole user of the integration, and I well understand why.
It is my first pull request, so please have mercy, i did change 5 lines to make the integration work again. The only checklist here i am sure about is
In general the integration could be a lot better, but I reached a solid basis to start with and I'd like to consolidate that before going forward with some new features.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: