Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Alarm panel and customizable arm modes #130187

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tomaszsluszniak
Copy link
Contributor

Breaking change

In some scenarios, the arm mode would be overwritten to the defaults. The arm mode has been moved to the arm mode mapping attribute where you can set a different mode for ARMED_AWAY and ARMED_HOME features.

Proposed change

The Satel system defines zones. Until this change, each zone has a separate alarm control panel. So if you wanted to arm the system via the alarm control panel you had to do this for each zone separately which is not very convenient. To make it a bit more clever, I added a parameter called one_alarm_panel to create only one alarm control panel entity which allows to arming of the whole Satel system (all of the zones) at once. No scripts are needed as the users used to do (it's not the best way of arming the Satel system in terms of the satel_integra package).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant