-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete binary door deprecation issue on unload at Home Connect #129947
Delete binary door deprecation issue on unload at Home Connect #129947
Conversation
Hey there @DavidMStraub, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we remove the issue when the entity unloads? async_will_remove_from_hass
?
No particular reason, I searched how it was done in other deprecations, I found the actual solution and I thought it was a good one. |
I mean, the async_will_remove_from_hass will always be called iirc, so it would work. |
Got it! I will use this solution then. Thank you very much for the info! |
Breaking change
Proposed change
The issue only could be ignored before and the integration didn't deleted the issue from the issue registry, so it would be there forever based on the documentation:
I added the option to confirm the issue so it can be deleted by the user whenever it wants to mark it as solved.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: