Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete binary door deprecation issue on unload at Home Connect #129947

Conversation

Diegorro98
Copy link
Contributor

Breaking change

Proposed change

The issue only could be ignored before and the integration didn't deleted the issue from the issue registry, so it would be there forever based on the documentation:

An issue will be kept in the issue registry until it's removed by the integration that created it or by the user fixing it.

I added the option to confirm the issue so it can be deleted by the user whenever it wants to mark it as solved.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2024

Hey there @DavidMStraub, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of home_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign home_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we remove the issue when the entity unloads? async_will_remove_from_hass?

@Diegorro98
Copy link
Contributor Author

Diegorro98 commented Nov 6, 2024

No particular reason, I searched how it was done in other deprecations, I found the actual solution and I thought it was a good one.
But your solution seems good. Is it the most correct way to avoid issues to be in the registry forever?

@joostlek
Copy link
Member

joostlek commented Nov 6, 2024

I mean, the async_will_remove_from_hass will always be called iirc, so it would work.

@Diegorro98
Copy link
Contributor Author

Got it! I will use this solution then. Thank you very much for the info!

@Diegorro98 Diegorro98 changed the title Allow to confirm binary door deprecation issue at Home Connect Delete binary door deprecation issue on unload at Home Connect Nov 6, 2024
@joostlek joostlek added this to the 2024.11.0 milestone Nov 6, 2024
@joostlek joostlek merged commit 0430e67 into home-assistant:dev Nov 6, 2024
32 checks passed
@Diegorro98 Diegorro98 deleted the home_connect_confirm_binary_door_deprecation_issue branch November 6, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants