Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bring-api to 0.9.1 #129702

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Bump bring-api to 0.9.1 #129702

merged 1 commit into from
Nov 3, 2024

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Nov 2, 2024

Fixes an error where the token refresh was not triggered because the bring API would return the wrong mimetype in the 401 response, which raised an uncatched ContentTypeError. These are now catched. Also instead of raising a parser error exception after already processing a 401 response, the parser error is now only logged to debug and an auth exception raised.

https://github.com/miaucl/bring-api/releases/tag/0.9.1

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 2, 2024

Hey there @miaucl, mind taking a look at this pull request as it has been labeled with an integration (bring) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bring can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bring Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member

bdraco commented Nov 3, 2024

@tr4nt0r Looks like a bugfix. Should it be tagged for beta?

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Nov 3, 2024
@tr4nt0r
Copy link
Contributor Author

tr4nt0r commented Nov 3, 2024

@bdraco yes, would be good to get this out soon

@bdraco bdraco added this to the 2024.11.0 milestone Nov 3, 2024
@bdraco bdraco merged commit 4d5c3ee into home-assistant:dev Nov 3, 2024
46 checks passed
@tr4nt0r tr4nt0r deleted the bump_bring-api branch November 3, 2024 16:52
bramkragten pushed a commit that referenced this pull request Nov 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cherry-picked cla-signed dependency integration: bring Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants