Skip to content

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Oct 28, 2024

This reverts commit 35b7c30.

Breaking change

Re-apply, with optimisations

We do not need to serialize/de-serialize the report unless --snapshot-update or --snapshot-details is set

Needs:

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Tested mqtt CI tests with coverage in (46.32s), so all seems well.
Thanks @epenet 👍

@epenet
Copy link
Contributor Author

epenet commented Oct 29, 2024

Looks good, Tested mqtt CI tests with coverage in (46.32s), so all seems well. Thanks @epenet 👍

@frenck the regression for regular tests has been addressed.
Are we OK to merge this one back in?

@epenet epenet added this to the 2024.11.0b0 milestone Oct 29, 2024
@MartinHjelmare
Copy link
Member

This isn't critical for the release, right?

@MartinHjelmare MartinHjelmare removed this from the 2024.11.0b0 milestone Oct 30, 2024
@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Oct 30, 2024
@epenet epenet force-pushed the 20241028-0839 branch 2 times, most recently from ae94895 to 1e3f87e Compare October 30, 2024 14:45
@epenet epenet force-pushed the 20241028-0839 branch 2 times, most recently from 6a6360d to 2fa819d Compare October 30, 2024 20:57
@frenck frenck merged commit 91157c2 into home-assistant:dev Nov 4, 2024
46 checks passed
@epenet epenet deleted the 20241028-0839 branch November 4, 2024 18:19
@epenet epenet mentioned this pull request Nov 5, 2024
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality core Hacktoberfest smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants