Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow binary sensor template to return state unknown #128861

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Oct 20, 2024

Breaking change

Previously, binary_sensor template entities could have the state on or off, and in case of YAML definition possibly unavailable. However, compared to other entities, it wasn't able to have the unknown state, which has been added.

So, a binary_sensor template entity can now have the on, off, unavailable, or unknown state.

You might need to adapt your templates, or automations/scripts to take this new unknown state into account.

Note: although other values are still possible, it is recommended to always return one of True/False/None.

Proposed change

As follow-up to #60193, and as alternative to #126909/#128963

Proposal for architecture discussion home-assistant/architecture#1148

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign template Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet marked this pull request as ready for review October 21, 2024 14:33
@epenet epenet requested a review from a team as a code owner October 21, 2024 14:33
@epenet epenet marked this pull request as draft October 22, 2024 09:04
@epenet epenet marked this pull request as ready for review October 22, 2024 11:00
@epenet epenet force-pushed the 20241020-2053 branch 3 times, most recently from 5f580c5 to f1b0a56 Compare October 24, 2024 14:39
@epenet epenet added this to the 2024.11.0b0 milestone Oct 29, 2024
@MartinHjelmare
Copy link
Member

I don't believe this is critical for the November release.

@MartinHjelmare MartinHjelmare removed this from the 2024.11.0b0 milestone Oct 30, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 8, 2024
@MartinHjelmare MartinHjelmare marked this pull request as draft November 19, 2024 08:37
@MartinHjelmare
Copy link
Member

The architecture discussion isn't approved yet. Draft for now.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Nov 26, 2024
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@Petro31
Copy link
Contributor

Petro31 commented Jan 31, 2025

Any reason this is still a draft?

@epenet
Copy link
Contributor Author

epenet commented Feb 1, 2025

Any reason this is still a draft?

Still waiting on arch discussion I think...
Cc @frenck / @MartinHjelmare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants