Fix availability for manual trigger entities

[gjohansson-ST]

Proposed change

Fix ManualTriggerEntity to not write state before calculating availability.

• Test availability first
• If available, render templates as normal
• If not available, no further rendering (all other properties remains as before)

Fair share of tests added.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Command line sensor not observing availability template #127960 fixes Rest sensor not updating (non-numeric value: 'None') #99942 fixes restful sensor availability template is not evaluated #119992 fixes Command Line entity Returns Errors despite being unavailable #133263
• This PR is related to issue:
• Link to documentation pull request: Add availability explanation to template advanced home-assistant.io#36910

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[flo-wer]

Does this also fix #99942 and #119992? Also does this replace #100079? If yes, it might be a good idea to copy the integration test for the rest sensor from your old PR.

[gjohansson-ST]

Does this also fix #99942 and #119992? Also does this replace #100079? If yes, it might be a good idea to copy the integration test for the rest sensor from your old PR.

Thanks @flo-wer I added those to be fixed by this PR and while this isn't specifically only for rest I guess including that test makes sense so I added it in.

[emontnemery]

For non-trigger template entities, we added the concept of "super template" which is always the availability template and which:

• Is rendered first
• Suppresses rendering of other templates if it's false

Can we do something similar here?

Also, we should preferably add direct tests of ManualTriggerEntity.
The existing test is in tests/components/template/test_manual_trigger_entity.py, it should be moved to tests/helpers/test_trigger_template_entity.py

[gjohansson-ST]

Created #130134 #130135 #130136 as preliminary PR's for this one

[emontnemery]

Looks pretty good, some questions though.

Also, we should make sure the way the availability template suppresses rendering of other templates is documented, both for the trigger case and for the state case.

[gjohansson-ST]

Here is a significant difference between state and trigger based templates.
If a state availability template fails to render, it assumes it's available
If a trigger availability template fails to render, it will go unavailable.

This PR does not change this behavior from before, but it's a notable difference on behavior which should be addressed.

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

[emontnemery]

I think this PR is no longer needed thanks to the changes in #140660, and I suggest we close it