Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add motion detected binary_sensor for tplink #127883

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Oct 7, 2024

Proposed change

This PR adds a new motion_detected binary sensor for tplink, exposed by hub-connected Tapo T100 sensors.
This PR itself has not been tested against a real device as I have none, but the backend support has been reported to work and the change itself is straightforward.
Tested to work with a real device.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 7, 2024

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Oct 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 8, 2024 12:33
@rytilahti rytilahti mentioned this pull request Oct 8, 2024
19 tasks
@rytilahti
Copy link
Member Author

rytilahti commented Oct 9, 2024

Just a quick update, I got a test device and it's working as expected. Added a screenshot to the PR desc.

@sdb9696
Copy link
Contributor

sdb9696 commented Oct 9, 2024

#128022 should address the device class issue.

@rytilahti rytilahti force-pushed the tplink/feat/motion_detection branch from a0188d2 to d2f3a0e Compare October 9, 2024 15:01
@rytilahti
Copy link
Member Author

I removed the translation indirection in favor of using the device class defaults, #128022 needs to be merged first before this can proceed.

@rytilahti rytilahti force-pushed the tplink/feat/motion_detection branch from d2f3a0e to 25b192a Compare October 9, 2024 16:13
@rytilahti rytilahti marked this pull request as ready for review October 9, 2024 16:13
@home-assistant home-assistant bot requested review from sdb9696 and joostlek October 9, 2024 16:13
Copy link
Contributor

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

frenck
frenck previously requested changes Oct 9, 2024
homeassistant/components/tplink/README.md Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 9, 2024 19:19
@rytilahti rytilahti marked this pull request as ready for review October 10, 2024 09:10
@Froggy232
Copy link

Hello,
Is it possible to know when / if this will land in the main docker image?
I need to connect a tepo T100 motion detector to homeassistant, I would just like to know how long approximately I need to wait for it to be supported, and I'm not very accustomed to github.
Of course, I would understand if there would be delay or long term impossibility, it's not a complain at all, but a plain question.
Thanks you!

@rytilahti
Copy link
Member Author

Hi @Froggy232! As this is a new feature, the earliest chance is for 2024.11 release coming up early next month. Given how simple this change is, and as the requested changes are related to our internal documentation, I'm rather confident this will make into that release .

@rytilahti rytilahti dismissed frenck’s stale review October 21, 2024 21:27

changes to readme.md were removed from this PR.

@rytilahti rytilahti merged commit 55ae43e into dev Oct 21, 2024
32 checks passed
@rytilahti rytilahti deleted the tplink/feat/motion_detection branch October 21, 2024 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapo T100 Motion Sensor motion detection not reporting anymore
6 participants