-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add motion detected binary_sensor for tplink #127883
Conversation
Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Just a quick update, I got a test device and it's working as expected. Added a screenshot to the PR desc. |
#128022 should address the device class issue. |
a0188d2
to
d2f3a0e
Compare
I removed the translation indirection in favor of using the device class defaults, #128022 needs to be merged first before this can proceed. |
d2f3a0e
to
25b192a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hello, |
Hi @Froggy232! As this is a new feature, the earliest chance is for 2024.11 release coming up early next month. Given how simple this change is, and as the requested changes are related to our internal documentation, I'm rather confident this will make into that release . |
changes to readme.md were removed from this PR.
Proposed change
This PR adds a new
motion_detected
binary sensor for tplink, exposed by hub-connected Tapo T100 sensors.This PR itself has not been tested against a real device as I have none, but the backend support has been reported to work and the change itself is straightforward.Tested to work with a real device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: