Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom account config flow setup #127750

Conversation

rjmarques
Copy link
Contributor

Proposed change

The Ovo Energy integration was not working when a user has access to more than 1 account. In particular, the code was incorrectly assigning the custom_account_id value in the client to True rather than the actual ID value because of incorrect use of an assigment expression. Additionally, the tests were not asserting on the account being set as part of the config flow.

The error trace I was seeing matches the one in: #119854. So I believe this PR also should address that issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rjmarques

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Oct 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented Oct 6, 2024

Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration (ovo_energy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ovo_energy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ovo_energy Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rjmarques rjmarques force-pushed the fix-multi-account-ovo-energy-integration branch from 9b51c3a to c1c7490 Compare October 6, 2024 17:40
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rjmarques

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@rjmarques rjmarques marked this pull request as ready for review October 6, 2024 17:42
@home-assistant home-assistant bot dismissed stale reviews from themself October 6, 2024 17:42

Stale

@rjmarques rjmarques force-pushed the fix-multi-account-ovo-energy-integration branch from c1c7490 to a57e63b Compare October 7, 2024 10:10
@frenck frenck added this to the 2024.10.2 milestone Oct 8, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rjmarques 👍

../Frenck

@frenck frenck merged commit d41b9be into home-assistant:dev Oct 8, 2024
30 of 31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OVO Energy Integration not working - Fail to setup
2 participants