-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_tasks action to Habitica integration #127687
Conversation
Hey there @asmfreak, @leikoilja, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
961bc2f
to
d551596
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
d551596
to
9fb8866
Compare
76b6d6f
to
df3d791
Compare
df3d791
to
dd418b1
Compare
dd418b1
to
f30a690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe also add more test coverage for this?
b068018
to
8836d90
Compare
0c744bd
to
63b97a0
Compare
63b97a0
to
177e6b0
Compare
c21a1b9
to
72eb1e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a merge conflict, can you take a look?
d36d586
to
15d5c42
Compare
592e9e3
to
492d825
Compare
492d825
to
642347b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Add get_tasks action
Proposed change
Adds a get_tasks action to the Habitica integration that returns the users tasks and offers various filter options to narrow the result.
This is an alternative way to the task sensors to retrieve task data. Currently the complete json data is dumped in the
extra_state_attributes
of the task sensors. With this it should be possible to remove or deprecate the extra_state_attributes of these sensors.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: