Improve history polling in Teslemetry #127614
Draft
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
Hacktoberfest
integration: teslemetry
small-pr
joostlek
reviewed
Oct 21, 2024
Comment on lines
+204
to
+208
| # Calculate seconds until next 5 minute period plus a random delay | ||
| delta = randint(310, 330) - (int(time()) % 300) | ||
| self.logger.debug("Scheduling next %s refresh in %s seconds", self.name, delta) | ||
| self.update_interval = timedelta(seconds=delta) | ||
| self._schedule_refresh() |
There was a problem hiding this comment.
I thought we had better functions to do this. I thought I once saw @gjohansson-ST comment about that, but not sure
There was a problem hiding this comment.
I suggested to turn off polling and setup an own caller instead.
Btw; async_config_entry_first_refresh() should not be overwritten. Use _async_setup() method instead
|
I put this in draft so please undraft once comments has been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
History data is only generated every 5 minutes, so this changes the coordinator to figure out when the next 5 minute interval is after the first refresh, and then just run every 5 minutes after that.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: