Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip the NYT Games token #127548

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Strip the NYT Games token #127548

merged 2 commits into from
Oct 4, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Oct 4, 2024

Proposed change

Strip the NYT Games token

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

# Conflicts:
#	homeassistant/components/nyt_games/config_flow.py
@frenck frenck merged commit ebfa2fb into home-assistant:dev Oct 4, 2024
30 checks passed
@joostlek joostlek deleted the strip-nyt-token branch October 4, 2024 10:55
frenck pushed a commit that referenced this pull request Oct 4, 2024
@frenck frenck mentioned this pull request Oct 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NYT Games "invalid authentication" due to character at end of string
2 participants