Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp isoformat in seventeentrack #127052

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

shaiu
Copy link
Contributor

@shaiu shaiu commented Sep 29, 2024

Proposed change

Return isoformat timestamp and not the object itself

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes 17Track integration returns strange datetime for timestamp #127037

  • The code change is tested and works locally.

  • Local tests pass. Your PR cannot be merged unless tests pass

  • There is no commented out code in this PR.

  • I have followed the [development checklist][dev-checklist]

  • I have followed the [perfect PR recommendations][perfect-pr]

  • The code has been formatted using Ruff (ruff format homeassistant tests)

  • Tests have been added to verify that the new code works.

@epenet epenet changed the title Fix timestamp isoformat Fix timestamp isoformat in seventeentrack Sep 30, 2024
@joostlek joostlek added this to the 2024.10.0 milestone Sep 30, 2024
@joostlek joostlek merged commit dce51b0 into home-assistant:dev Sep 30, 2024
31 checks passed
@shaiu shaiu deleted the shaiu-fix-timestamp branch September 30, 2024 10:42
frenck pushed a commit that referenced this pull request Sep 30, 2024
KoBOLL pushed a commit to DevPocket/homeassistant-core that referenced this pull request Oct 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

17Track integration returns strange datetime for timestamp
3 participants