Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytouchlinesl to 0.1.6 #126912

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

jnsgruk
Copy link
Contributor

@jnsgruk jnsgruk commented Sep 27, 2024

Proposed change

Updates pytouchlinesl to 0.1.6.

Changes from 0.1.5: jnsgruk/pytouchlinesl@0.1.5...0.1.6

Main takeaway is this commit

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jnsgruk
Copy link
Contributor Author

jnsgruk commented Sep 27, 2024

@joostlek I think I got it - seems like the API is giving inconsistent fields on certain types depending on the account.

Upstream change is here: jnsgruk/pytouchlinesl@6076a60

@frenck frenck changed the title chore(deps): bump pytouchlinesl to 0.1.6 Update pytouchlinesl to 0.1.6 Sep 27, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft September 27, 2024 12:31
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek added this to the 2024.10.0 milestone Sep 27, 2024
@jnsgruk
Copy link
Contributor Author

jnsgruk commented Sep 27, 2024

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

Done! Thanks :) this should be fine for a patch release - it just marks some fields as Optional in the pydantic model.

@jnsgruk jnsgruk marked this pull request as ready for review September 27, 2024 12:44
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jnsgruk 👍

The test failure is unrelated, so I'll go ahead and merge this one in.

../Frenck

@frenck frenck merged commit 8bdd81f into home-assistant:dev Sep 27, 2024
40 of 41 checks passed
@jnsgruk jnsgruk deleted the pytouchlinesl016 branch September 27, 2024 13:24
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 27, 2024
frenck pushed a commit that referenced this pull request Sep 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roth Touchline SL failing to setup
3 participants