Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Energy History to Tesla Fleet #126878

Open
wants to merge 37 commits into
base: dev
Choose a base branch
from
Open

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Sep 27, 2024

Proposed change

Add Energy History to Tesla Fleet. This is a fork of the work that @JEMcats did, to fast track it.

This PR is mostly content which has already been merged as #126166
It will superseed #126003

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Bre77
Copy link
Contributor Author

Bre77 commented Oct 24, 2024

This PR is failuring due to coverage, but everything changed here is covered, so I am addressing the coverage issue in #129116

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Nov 8, 2024
@Bre77 Bre77 marked this pull request as ready for review November 14, 2024 06:57
@home-assistant home-assistant bot requested a review from joostlek November 14, 2024 06:57
@Bre77
Copy link
Contributor Author

Bre77 commented Nov 28, 2024

@joostlek any chance we can get this back on your radar? I've got people bugging me for this feature.

@audiobruce
Copy link

@joostlek we'd love you to do a final review and get this change merged please 👍 Powerwall owners will be stoked.

@audiobruce
Copy link

@joostlek we'd love you to do a final review and get this change merged please 👍 Powerwall owners will be stoked.

@joostlek pleeeeeease :)

@audiobruce
Copy link

@joostlek we'd love you to do a final review and get this change merged please 👍 Powerwall owners will be stoked.

@joostlek pleeeeeease :)

@Bre77 is there a HACS version of Tesla Fleet and if so have these changes already been applied? Just wanting the energy / kWh data from PW3!

@JEMcats
Copy link
Contributor

JEMcats commented Dec 12, 2024

Try this. v2.1.0 brings energy history.

@Bre77
Copy link
Contributor Author

Bre77 commented Dec 12, 2024

Try this. v2.1.0 brings energy history.

I managed to even get it into core for Teslemetry, no HACS required. But it needs Teslemetry which isn't free.

There is no HACS for tesla_fleet and I have no intention of maintaining one.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like that the island thing can be true or false, making it a binary sensor

homeassistant/components/tesla_fleet/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 18, 2024 15:25
@Bre77
Copy link
Contributor Author

Bre77 commented Dec 18, 2024

I feel like that the island thing can be true or false, making it a binary sensor

I have removed that change from the PR. It does have a couple of different states that could boil down to a binary. Ill handle that in a seperate PR.

@Bre77 Bre77 marked this pull request as ready for review December 18, 2024 22:10
@home-assistant home-assistant bot requested a review from joostlek December 18, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tesla Fleet Needs device_class type Energy
5 participants