-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use aiohasupervisor for store APIs #126780
base: dev
Are you sure you want to change the base?
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -547,14 +554,14 @@ async def test_service_calls( | |||
) | |||
await hass.async_block_till_done() | |||
|
|||
assert aioclient_mock.call_count == 22 | |||
assert aioclient_mock.call_count + len(supervisor_client.mock_calls) == 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers - the increase in call count here is not actually a change. If you look in #125926 you'll see that I decreased each of these numbers by 2 to reflect the fact that mocking had changed for 2 calls we were previously making. Those 2 calls were going through the mocked client library as opposed to the mocked websession.
I realized in this PR that a better way to change these tests was to add the mock calls to these two things together to show that the call count truly had not changed. So as a result I had to increase these numbers back to what they were before the prior PR.
Proposed change
Continuing off recent PRs in the supervisor integration, migrate all calls to Supervisor's
store
API to run through aiohasupervisor.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: