-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wake word interception to a subscription #125629
Change wake word interception to a subscription #125629
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't merge this until frontend confirms they are happy.
Also, please complete the tests.
bc6caf2
to
e6b71e0
Compare
686201f
to
011f875
Compare
Test failure appears unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can be merged once approved by frontend.
* Allow stopping intercepting wake words * Make wake word interception a subscription * Keep future * Add test for unsub
Breaking change
Proposed change
Modifies the
assist_satellite/intercept_wake_word
websocket command to be a subscription instead. This will allow it to be cancelled within the UI. Additionally, starting a second interception will cancel the first one.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: