Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server side events to Smlight integration #125553

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

tl-sl
Copy link
Contributor

@tl-sl tl-sl commented Sep 9, 2024

Breaking change

Proposed change

Add server side events (SSE) client to Smlight integration and hook them up for switches platform. SSE events will also be used for update entities and a couple of other sensors later.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

homeassistant/components/smlight/switch.py Show resolved Hide resolved
tests/components/smlight/conftest.py Outdated Show resolved Hide resolved
tests/components/smlight/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Paarth Shah <mail@shahpaarth.com>
tests/components/smlight/conftest.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 10, 2024 14:09
@tl-sl tl-sl marked this pull request as ready for review September 11, 2024 08:46
@home-assistant home-assistant bot requested a review from joostlek September 11, 2024 08:46
@joostlek joostlek merged commit b8ce687 into home-assistant:dev Sep 11, 2024
29 checks passed
@joostlek
Copy link
Member

Should the integration type be changed to local_push?

@tl-sl
Copy link
Contributor Author

tl-sl commented Sep 11, 2024

no, the majority of sensors are still polled. Events are mainly only available for settings changes and updates.

@joostlek
Copy link
Member

We categorize them with the best way they can do it

@tl-sl
Copy link
Contributor Author

tl-sl commented Sep 11, 2024

well in that case I suppose it should be changed then

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@tl-sl tl-sl deleted the sse-part1 branch September 23, 2024 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants