Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duke Energy Integration #125489

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Duke Energy Integration #125489

merged 7 commits into from
Sep 11, 2024

Conversation

hunterjm
Copy link
Member

@hunterjm hunterjm commented Sep 8, 2024

Proposed change

Adding a new integration for Duke Energy. Initially this integration will just manually insert statistics for use in the energy dashboard similar to the Opower integration. Also like the Opower integration, the data is up to 48 hours old, so must be manually inserted into the statistics database. It is also possible to retrieve billing data which could be added in a later PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

homeassistant/components/duke_energy/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/duke_energy/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/duke_energy/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/duke_energy/manifest.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 8, 2024 05:06
@home-assistant
Copy link

home-assistant bot commented Sep 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@hunterjm hunterjm marked this pull request as ready for review September 8, 2024 18:18
@home-assistant home-assistant bot requested a review from joostlek September 8, 2024 18:18
@hunterjm
Copy link
Member Author

hunterjm commented Sep 8, 2024

Failing tests are unrelated. Possible fixes in #125522 and #125534

homeassistant/components/duke_energy/__init__.py Outdated Show resolved Hide resolved
tests/components/duke_energy/conftest.py Outdated Show resolved Hide resolved
tests/components/duke_energy/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/duke_energy/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/duke_energy/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 10, 2024 15:41
@hunterjm hunterjm marked this pull request as ready for review September 11, 2024 04:14
@home-assistant home-assistant bot requested a review from joostlek September 11, 2024 04:14
@hunterjm
Copy link
Member Author

Opening this back up for re-review as 1) tests pass locally, 2) potential CI fix is here: #125712, and 3) It's bedtime 😄

I'll rebase and re-run CI if it's fixed in the morning.

@joostlek joostlek merged commit 356bca1 into home-assistant:dev Sep 11, 2024
43 checks passed
@hunterjm hunterjm deleted the duke_energy branch September 11, 2024 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants