Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include requirements_test_pre_commit.txt in pre-commit hassfest #125388

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented Sep 6, 2024

Proposed change

With the changes in #124855, the pre-commit script now also has to run hassfest when the requirements_test_pre_commit.txt file is changed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@autinerd autinerd requested a review from a team as a code owner September 6, 2024 05:10
@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Sep 6, 2024
@@ -83,7 +83,7 @@ repos:
pass_filenames: false
language: script
types: [text]
files: ^(homeassistant/.+/(icons|manifest|strings)\.json|homeassistant/brands/.*\.json|homeassistant/.+/services\.yaml|script/hassfest/(?!metadata|mypy_config).+\.py|requirements_test.txt)$
files: ^(homeassistant/.+/(icons|manifest|strings)\.json|homeassistant/brands/.*\.json|homeassistant/.+/services\.yaml|script/hassfest/(?!metadata|mypy_config).+\.py|requirements_test.txt|requirements_test_pre_commit.txt)$
Copy link
Contributor

@epenet epenet Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also include homeassistant/package_constaints.txt?

-c homeassistant/package_constraints.txt
-r requirements_test_pre_commit.txt

cc @edenhaus

@frenck
Copy link
Member

frenck commented Sep 23, 2024

This has been solved in a different PR at this point. Closing this one.

Thanks, @autinerd 👍

../Frenck

@frenck frenck closed this Sep 23, 2024
@autinerd
Copy link
Contributor Author

@frenck it seems like #125726 reverted it accidentally, so that it doesn't work (again). I can alter my change, so that it is the same as what had been merged already.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
@frenck frenck reopened this Sep 25, 2024
@home-assistant home-assistant unlocked this conversation Sep 26, 2024
@frenck frenck modified the milestone: 2024.10.0 Sep 28, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @autinerd 👍

../Frenck

@frenck frenck merged commit f516e53 into home-assistant:dev Sep 28, 2024
44 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants