Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in squeezebox #125352

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix typo in squeezebox #125352

merged 1 commit into from
Sep 5, 2024

Conversation

peteS-UK
Copy link
Contributor

@peteS-UK peteS-UK commented Sep 5, 2024

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 5, 2024

Hey there @rajlaud, mind taking a look at this pull request as it has been labeled with an integration (squeezebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of squeezebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign squeezebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

joostlek commented Sep 5, 2024

This was already released right?

@joostlek joostlek changed the title Spelling Correction on SERVER_MODEL Fix typo in squeezebox Sep 5, 2024
@joostlek joostlek merged commit b0bfe71 into home-assistant:dev Sep 5, 2024
24 checks passed
@joostlek joostlek added this to the 2024.9.1 milestone Sep 5, 2024
@peteS-UK
Copy link
Contributor Author

peteS-UK commented Sep 5, 2024

This was already released right?

@joostlek No, this builds on 122473, which you've merged earlier today but isn't released. If this is going to be in 2024.9.1, then that one should be as well. There's a few PR which on squeezebox which I guess should also be on the 2024.9.1 milestone as they're also merged and at least the typing ones may also be linked to 122473.

#124732
#125161
#125166
#125271

@joostlek
Copy link
Member

joostlek commented Sep 5, 2024

then we should not tag it :)

@joostlek joostlek removed this from the 2024.9.1 milestone Sep 5, 2024
@joostlek
Copy link
Member

joostlek commented Sep 5, 2024

Thanks!

@peteS-UK
Copy link
Contributor Author

peteS-UK commented Sep 5, 2024

then we should not tag it :)

Agree - probably best to get all of these released together.

@joostlek
Copy link
Member

joostlek commented Sep 5, 2024

We only allow bugfixes in patch releases, everything else goes into the next release

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants