-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix energy sensor for ThirdReality Matter powerplug #125140
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
native_unit_of_measurement=UnitOfEnergy.WATT_HOUR, | ||
suggested_display_precision=3, | ||
state_class=SensorStateClass.TOTAL_INCREASING, | ||
measurement_to_ha=lambda x: x / 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am always confused with these conversions. taking the measurement_to_ha
in account, does that mean the number we get from the device are in mWh?
(looking to see if that conversion is obsolete)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the measurement we got is milliwatt hours
Thank you all for the quick turnaround and push on this unit fix 🥰 |
Proposed change
Fix small conversion error (watt-hour vs kilowatt-hour) for ThirdReality Matter powerplugs.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: