Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix area registry indexing when there is a name collision #125050

Merged

Conversation

arturpragacz
Copy link
Contributor

Proposed change

Fix bug in area registry indexing.

If the area name was already in use, it would've raised exception, but some of the indices were already changed, leaving the state as incoherent.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@arturpragacz arturpragacz requested a review from a team as a code owner September 2, 2024 03:10
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Sep 2, 2024
@bdraco bdraco added this to the 2024.9.0 milestone Sep 2, 2024
@bdraco bdraco changed the title Fix area registry indexing Fix area registry indexing when there is a name collision Sep 2, 2024
@bdraco
Copy link
Member

bdraco commented Sep 2, 2024

Thanks @arturpragacz

@bdraco bdraco merged commit fb27297 into home-assistant:dev Sep 2, 2024
40 checks passed
@arturpragacz arturpragacz deleted the helpers/fix-area-registry-indexing branch September 3, 2024 01:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants