-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nmi
(nautical miles) as valid distance unit
#124723
Add nmi
(nautical miles) as valid distance unit
#124723
Conversation
This PR is changing our entity model. Before we can review this PR there needs to be approval in a discussion in our architecture repository. https://github.com/home-assistant/architecture/discussions https://developers.home-assistant.io/docs/core/entity#changing-the-entity-model |
yeah you're right - will open a proper discussion 👍 |
discussion started: home-assistant/architecture#1129 |
this has been approved home-assistant/architecture#1129 (comment), so un-draft it 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mib1185 👍
../Frenck
Proposed change
We already have knots (kn) as valid speed unit, which is just nmi per hour, we should also support nmi (nautical miles) as valid distance unit.
reference: https://community.home-assistant.io/t/add-nautical-miles-as-a-valid-unit-for-distance-device-class/754284
Type of change
Additional information
nmi
(nautical miles) as valid distance unit home-assistant.io#34462nmi
(nautical miles) as valid distance unit developers.home-assistant#2293Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: