Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for fetching buienradar weather data #124597

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mjj4791
Copy link
Contributor

@mjj4791 mjj4791 commented Aug 25, 2024

Proposed change

Some users have reported the component hitting the 10 second timeout and thus being unable to fetch any weather data.
With this PR the 10-second asyncio timeout is replaced with a 60-seconds aiohttp ClientTimeout. This both increases the imeout value and applies the timeout to the actual http request.
This should/could mitigate the issue for systems that are either very busy or which experience very slow HTTP responses.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ties, @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration (buienradar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of buienradar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign buienradar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title Increase timeout for fetching weather data Increase timeout for fetching buienradar weather data Aug 26, 2024
@mjj4791
Copy link
Contributor Author

mjj4791 commented Aug 31, 2024

@ties @RobBie1221 could you please approve this PR (again)? I had to pull in dev changes, since branch was out of date

@joostlek joostlek added this to the 2024.9.0 milestone Sep 3, 2024
@joostlek joostlek merged commit 42ed7fb into home-assistant:dev Sep 3, 2024
26 checks passed
bramkragten pushed a commit that referenced this pull request Sep 3, 2024
Increase timeout for fetching weather data
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buienradar unable to retrieve data
5 participants